Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T TIDO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 110
    • Issues 110
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • subugoesubugoe
  • emoemo
  • TIDO
  • Merge requests
  • !129

Draft: feature/#172: Created a new keys button and modal to display text style labels

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed dindigala requested to merge feature/#172-text-styles-key into develop Apr 07, 2021
  • Overview 77
  • Commits 10
  • Pipelines 10
  • Changes 4

Feature

Summary

This MR provides…

  • Transfer intranet text styling specification info to key modal.

Entrypoint: https://ahikar-dev.sub.uni-goettingen.de/api/textapi/ahikar/arabic-karshuni/collection.json

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I adjusted other parts of the documentation (if applicable)

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • Yes, you can test by following these steps: A new KEY button is created at bottom of text panel. When you click on it, a modal is opened and you can view the labels of related text styles explained apart from those displayed from annotation panel. Since most of the keys in text panel are handled from annotation panel, the display of keys button appears only when there are any specific keys to display.

EX: In Karshuni Collection - Cod. Arab. 236 Copenhagen - Sheet 2a, 5a, 5b...

  • No, it is not possible.

Changelog

  • I added a statement to the CHANGELOG.

Related Tickets

Add all related issues and especially those to be closed.

Related

Closes

Logs and Screenshots

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Edited May 19, 2021 by dindigala
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/#172-text-styles-key