Skip to content

refactor: annotation tabs have to be generic

dindigala requested to merge issue/#292-annotation-tabs into develop

Feature

Summary

This MR provide:

To display tabs accordingly to the data provided.

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I adjusted other parts of the documentation (if applicable)

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • [*] Yes, you can test by following these steps: Refactored the tabs logic to display according to the data that comes from backend. If we do not have Motifs, we observe only Editorial tab and vice-versa. If no annotation - than we see a direct notification message.

EX: Only Motifs: Bibl. Nat. France syr. 434 - Sheet 187r Only Editorial: Brit. Libr. Or. 2313 - Sheet 174v No Annotations: Brit. Lib. Add. 7200 - Sheet 114r

  • No, it is not possible.

Changelog

  • I added a statement to the CHANGELOG.

Related Tickets

Add all related issues and especially those to be closed.

Related

Closes

Logs and Screenshots

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Edited by schneider210

Merge request reports