Skip to content

add config option to switch off the header

schneider210 requested to merge feature/#30-header-config into develop

Feature

We welcome every new feature to the upstream branch!

Please fill in the following information about your feature. Feel free to delete sections that doesn't suit the case you're dealing with.

Summary

This MR provide a config option inside index.html to switch off the header

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Use Cases

If you can, please provide use cases for this feature.

A project will use the Viewer embedded on an existing website and there's just not enough room

Documentation

Shall we add your feature to the documentation?

  • I've already did it!
  • At least I added a headline to the documentation.

Function Documentation

  • Of course I provided all my functions with an appropriate documentation.

Are there parts of the documentation we have to adjust

  • No.
  • Yes, but I'd like someone else to do it.
  • Yes, and I already did!

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • Yes, you can test by following these steps:

locate the index.template.html file inside the project root, find the script-section and set the value of the "header"-key to false

  • No, it is not possible.

Changelog

  • I added a statement to the CHANGELOG.

Related Tickets

Add all related issues and especially those to be closed.

Related

Closes

Configurability of the Header

Logs and Screenshots

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Merge request reports