refactor: default language change when the language switch is turned off
Bug fix
Summary
Apart from what is mentioned in the main ticket you are going to close with this MR, tell us what you have done to achieve this goal.
- In gfl we have the requirement that the viewer should be configurable for german only. Default german, language toggle false. In the current version it does not work.
- Updated the translations according to the suggestions in comments - issue-40
To Test:
-
On
develop
branch inindex.template.html
change the following:"lang": "de-de", "language-switch": false,
-
run the app and it loads in English language instead of German.
Fix:
-
Please pull the branch
issue/#340-default-language
in local to test. -
Change the following in
index.template.html
:"lang": "de-de", "language-switch": false,
-
Load the application and the default app loads in German language even though the toggle switch is off.
Does the result of the MR comply to our "definition of done"?
-
Unit tests passed -
Code reviewed -
Acceptance criteria met -
Functional tests passed -
Non-Functional requirements met -
Product Owner accepts the User Story
Related
Closes
GFL Issue: issue-40
tido: #340 (closed)
Changelog
-
I added a statement to the CHANGELOG.
Documentation
-
I updated the README (if applicable) -
I provided my functions with appropriate documentation
Edited by dindigala