Skip to content

feat: text panel error message notification

dindigala requested to merge issue/#341-text-error-handling into develop

Feature

Summary

This MR provides:

  • Displaying of Error Message when there is no Text provided.

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Documentation

  • I updated the README (if applicable)
  • I provided my functions with appropriate documentation
  • I adjusted other parts of the documentation (if applicable)

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • Yes, you can test by following these steps:

To Test:

  • In GFL (which is running already in local) please change the following to simulate server error:

    • Navigate to vendor/subugoe/emo-bundle/Resources/config/routing.yml inside the GFL project folder.

    • change this line

      defaults: { _controller: SubugoeEMOBundle:Presentation:content } to

      defaults: { _controller: SubugoeEMOBundle:Presentation:mycontent }

  • checkout the branch issue/#341-text-error-handling in TIDO repo which has the GFL single manifest entry point and run the app.

  • We can observe the notification error message is getting displayed inside text panel.

  • To Test the existing features of TIDO please use https://ahikar.sub.uni-goettingen.de/api/textapi/ahikar/syriac/collection.json as the entrypoint.

  • No, it is not possible.

Changelog

  • I added a statement to the CHANGELOG.

Related Tickets

Add all related issues and especially those to be closed.

Related

Closes

#341 (closed)

Logs and Screenshots

/cc Mathias Göbel, Frank Schneider, Michelle Weidling

Merge request reports