Skip to content

Feature/#35 optimize toggle linking

schneider210 requested to merge feature/#35-optimize-toggle-linking into develop

Feature

We welcome every new feature to the upstream branch!

Please fill in the following information about your feature. Feel free to delete sections that doesn't suit the case you're dealing with.

Summary

This MR provides:

  • image panel and toggle button toggle due to availability og imageurl, e.g. no url, no panel / toggle and vice vers
  • panelnames are configurable. togglenames and captions update accordingly
  • fix order of the toggle buttons. they correspond to the panel order now

Does the result of the MR comply to our "definition of done"?

  • Unit tests passed
  • Code reviewed
  • Acceptance criteria met
  • Functional tests passed
  • Non-Functional requirements met
  • Product Owner accepts the User Story

Use Cases

If you can, please provide use cases for this feature.

Documentation

Shall we add your feature to the documentation?

  • I've already did it!
  • At least I added a headline to the documentation.

Function Documentation

  • Of course I provided all my functions with an appropriate documentation.

Are there parts of the documentation we have to adjust

  • No.
  • Yes, but I'd like someone else to do it.
  • Yes, and I already did!

Tests

Are we able to test this new feature?

  • Yes, everything can be done via unit tests.
  • Yes, you can test by following these steps: play around with the bools in the index.template.html. toggle either values from true to false and rename the panels. to test, if the imagepanel and the toggle are hidden, you have to fake the imageurl: goto App.vue@102 and set the imageurl to an empty string. the image panel and the image toggle disappear.
  • No, it is not possible.

Changelog

  • I added a statement to the CHANGELOG.

Related Tickets

Add all related issues and especially those to be closed.

Related

Closes

Logs and Screenshots

/cc Manikanth Dindigala,Michelle Weidling

Merge request reports

Loading