Resolve "Serialisierung Kommentare anpassen"

Closes #52 (closed)

assigned to @zeterberg

added 1 commit

• 2e7912a6 - feat(note): implement schema changes (label as required child element) for...

Compare with previous version

added 1 commit

• 6c3ed698 - feat(notes): select and order the notes

Compare with previous version

added 1 commit

• 0e8b4f70 - feat(function): make button generation a function

Compare with previous version

added 1 commit

• d5fd5979 - fix(epigraphic-commentaries): get all corresponding ephigraphic commentaries

Compare with previous version

added 1 commit

• 6d9153db - feat(commentaries): serialize each commentary only once per line

Compare with previous version

added 1 commit

• 671c9050 - fix(xml-commentaries): remove xml-commentaries and make all files more beautiful

Compare with previous version

added 1 commit

• 70ef3530 - fix(namespaces): remove namespaces from output HTML

Compare with previous version

added 1 commit

• 37831e2c - fix(epigraphical commentaries): serialize corresponding notes

Compare with previous version

@tillmann.doenicke ich glaube, ich habe die Serialisierung ganz ordentlich angepasst. Es sind zahlreiche Veränderungen, auch weil die Sortierung der Kommentare pro Zeiel extrem Komplex geworden ist (nach Hierarchie im XML-Dokument, nach Typen (nicht alphabetisch!) und dann noch nach Anzahl der Typen). Aber es funktioniert nun. Angehängt sind zwei HTML Dateien für den Output. Schau doch mal drüber, ob das soweit passt - dann könntest du ja auch das CSS entsprechend anpassen. Das betrifft insbesondere folgende Anforderung:

• Das Element für die Kommentar-Überschrift (label) und der Typ des Kommentars (note@type) sollen den "Button" repräsentieren, um den Kommentar ein- und auszuklappen (also komplett grün und bold dargestellt)2024-06-03_c_KTU_1.14_II.philology.html

2024-06-03_c_KTU_1.14_II.transcription.html

Außerdem frage ich mich, ob wir nicht die HTML-Serialisierung (und damit auch die HTML-Struktur) von Transliteration und Vokalisation noch stärker angleichen könnten @tillmann.doenicke. Das betrifft den div vom notes-Container: In Transliteration:

<xsl:if test="$correspondingNotes != ''">
                <div class="notes-container">
                    <ul>
                        <xsl:for-each select="functx:distinct-deep($correspondingNotes)">
                            <xsl:apply-templates select="."/>
                        </xsl:for-each>
                    </ul>
                </div>
            </xsl:if>

--> Wenn es keine Kommentare zu der Zeile gibt, gibt es das div gar nicht In Vokalisation:

<div class="notes-container">
                <xsl:if test="$correspondingNotes != ''">
                    <ul>
                        <xsl:for-each select="functx:distinct-deep($correspondingNotes)">
                            <xsl:apply-templates select="."/>
                        </xsl:for-each>
                    </ul>
                </xsl:if>
            </div>

--> Wenn es keine Kommentare zu der Zeile gibt, gibt es zwar das div, aber es ist leer.

added 1 commit

• 88c4bea2 - fix(ephigraphical commentaries): make notes unique per line

Compare with previous version

added 5 commits

• 88c4bea2...e112e6cf - 4 commits from branch master
• b97849d8 - Merge branch 'master' into '52-serialisierung-kommentare-anpassen'

Compare with previous version

added 1 commit

• 94657aed - fix(w): resolve merge conflict

Compare with previous version

added 1 commit

• 3ca27db8 - fix(w): resolve merge-conflicts

Compare with previous version

added 8 commits

• 3ca27db8...b31ee785 - 7 commits from branch master
• 5318aaa8 - Merge branch 'master' into '52-serialisierung-kommentare-anpassen'

Compare with previous version

added 23 commits

• 5318aaa8...085575e5 - 22 commits from branch master
• ae4842b2 - Merge branch 'master' into '52-serialisierung-kommentare-anpassen'

Compare with previous version

added 17 commits

• ae4842b2...b28215b1 - 16 commits from branch master
• e8db1d4d - Merge branch 'master' into '52-serialisierung-kommentare-anpassen'

Compare with previous version

added 1 commit

• b94c21c1 - resolve merge conflicts

Compare with previous version

added 1 commit

• a9c76908 - fix(poetological): exclude prefix tei

Compare with previous version

added 1 commit

• 749fdb68 - fix(notes-container): implement function for creation of notes-container

Compare with previous version

added 1 commit

• 9b68fdf5 - fix(note): add span for note-type

Compare with previous version

added 1 commit

• 27b6cef2 - feat(notes): adjust notes css

Compare with previous version

resolved all threads

added 1 commit

• 2afb387e - feat(notes): add ellipsis for non-expanded notes

Compare with previous version

assigned to @tillmann.doenicke and unassigned @zeterberg

requested review from @zeterberg

marked this merge request as ready

approved this merge request

merged

mentioned in commit d5cb732c