Unblock future development

For me no development can be done until the following things are not done:

• Migrate from Bootstrap to Material design in vuetify. Part of #39 (closed).
• Install and configure decent logging capabilities. See here.
• Refactor CI/CD scripts. See #48 (closed).
• Remove all legacy code without breaking things. See #46 (closed).
• Prepare pre-commit hooks in order to enforce coding conventions. See here.
• Complete #43 (closed) as discussed.

When all of this is done, we migrate everything to a new clean master. Then and only then development of other features can begin. (The new student page should serve as an example within master, while further development still happens in that branch.)

• Merge everything into master.

changed milestone to %Creating the new project structure

mentioned in issue #45 (closed)

• Also remove issues that have become obsolete. I think this includes: #23 (closed). TBC.

changed the description

marked the checklist item Remove all legacy code without breaking things. See #46 (closed). as completed

marked the checklist item Complete #43 (closed) as discussed. as completed

marked the checklist item Install and configure decent logging capabilities. See here. as completed

marked the checklist item Migrate from Bootstrap to Material design in vuetify. Part of #39 (closed). as completed

Prospector (Pylint to be specific) can not really be made working with pre-commit due to PyLint either not starting at all or having problems with import statements, showing something like

backend/core/views.py
  Line: 5
    pylint: import-error / Unable to import 'core.permissions'
  Line: 6
    pylint: import-error / Unable to import 'core.serializers'

If someone can get it working that would be awesome (i can't at the moment). Sorry for this lousy description, i tried getting this sh** to work for 3 hoursand would like to fling my laptop against the wall.

Whoops, sorry to hear that. I did not know it would be that annoying. I’ll have a look at it myself on Wednesday afternoon, if it does work until Thursday, we should get rid of it and leave pre commit code formatting to each developer.

marked the checklist item Refactor CI/CD scripts. See #48 (closed). as completed

Well, actually I see the problem from here. pylint cannot work (or at least not find the core package) if executed not inside of the backend folder (see the path backend/core/views.py) where the .pylint resides.

Can you maybe push your progress onto some other branch? :)

Pushed, sorry for the delay.

mentioned in commit e5d0f2e6

Hm, I not satisfied with this. That's not the way this tool is supposed to be used.

After long last, i've found a solution that works and doesn't even depend on pre-commit (screw that). Just add a pre-commit file to .git/hooks with the following content:

#!/bin/bash

cd backend
unset GIT_DIR
git diff  --cached --name-only --relative | xargs prospector --uses django

Prospector must be installed, so either the virtualenv must be activated during commit, or it mus be installed system-wide.

marked the checklist item Prepare pre-commit hooks in order to enforce coding conventions. See here. as completed

mentioned in merge request !15 (merged)

closed via merge request !15 (merged)

closed via commit fa26fc3e

mentioned in issue #26 (closed)