Skip to content
Snippets Groups Projects

Resolve "Logout of tutors after inactivity"

Merged Resolve "Logout of tutors after inactivity"
22-logout-of-tutors-after-inactivity into master
All threads resolved!
Merged Jan Maximilian Michal requested to merge 22-logout-of-tutors-after-inactivity into master
All threads resolved!

Closes #22 (closed).

Merge request reports

Pipeline #6164 passed

Stage: build
Stage: test

Pipeline passed for 0a0a3f3a on 22-logout-of-tutors-after-inactivity

Test coverage 85.00% (0.00%) from 1 job

Merged by robinwilliam.hundtrobinwilliam.hundt 7 years ago (Dec 17, 2017 11:29am UTC)

Loading

Pipeline #6166 failed

Stage: build
Stage: test
Stage: pages
Stage: staging

Pipeline failed for b1e73551 on master

Test coverage 85.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
core/views.py
17 17 return Response({'role': type(request.user.get_associated_user()).__name__})
18 18
19 19
20 @api_view()
  • Jan Maximilian Michal
  • Jan Maximilian Michal
  • Jan Maximilian Michal
    Jan Maximilian Michal @j.michal ·
    Author Owner

    Ok, this branch got rather big, but the changes are important and they currently block future development. The comments I added should be taken care of before the merge. Apart from that - looks very good to me.

    In the related issue two more points on the checklist are still open. I propose we transfer them to a new ticket that does not have priority.

    It is needless to say that this branch got too big which makes it rather hard to review it. However, I believe that is largely due to the fact that several branches were merged into this one and there was not enough time to review them earlier.

  • Jan Maximilian Michal
    Jan Maximilian Michal @j.michal ·
    Author Owner

    Please clean up related MR if you merge different feature branches into one. See !18 (closed) and !22 (closed).

  • robinwilliam.hundt added 1 commit

    added 1 commit

    • ec823496 - token/username etc. is saved in sessionstorage

    Compare with previous version

  • robinwilliam.hundt resolved all discussions

    resolved all discussions

  • robinwilliam.hundt added 1 commit

    added 1 commit

    • 0a0a3f3a - removed get_exam_module view

    Compare with previous version

  • robinwilliam.hundt merged

    merged

  • robinwilliam.hundt mentioned in commit b1e73551

    mentioned in commit b1e73551

    • Please register or sign in to reply