- Jan 24, 2023
-
-
michaelroytman authored
This commit fixes a bug in the PII sharing consent dialog. The bug resulted in bizarre behavior when there were more than one LTI component in a unit. For example, if there were two LTI inline launches in a unit, two "OK" button would appear in a single component, instead of in their respective components. Another example is that clicking the "View resource in a [modal|new] window" buttons under two LTI components resulted in the "OK" and "Cancel" buttons as well as the PII sharing prompt appearing in a single component, instead of in their respective components. This is because the dialog-container div that is dynamically created in the Javascript was not scoped to the LTI component, so there was a div with a id of "dialog-container" for each component configured to share PII. When dynamically inserting and removing buttons and the PII sharing prompt, the Javascript would simply find the first div with the dialog-container ID and operate on it, instead of the div appropriate to the component the user is interacting with.
-
- Dec 15, 2022
-
-
michaelroytman authored
This commit fixes a bug in the way that the the form_url is used in the Javascript. For LTI modal launches in the courseware microfrontend (MFE), the Javascript prepends the value of window.location.origin to the form_url when sending a message via postMessage to window.parent. This is because the form_url included in the template by the XBlock handler does not include a port and hostname for LTI 1.1 launches. In LTI 1.3, however, the form_url should include the port and hostname, because it's user input (e.g. fields on the XBlock). Because of this, LTI 1.3 modal launches do not work, because the Javascript appends a port and hostname to a URL that already has a port and hostname, resulting in something like "http://localhost:18000http//localhost..." This commit changes the way that the launch URL is calculated by the Javascript. The version of LTI being used is included in the template by the Python code, which is read by the Javascript. The Javascript then adds the port and hostname for LTI 1.1 form URLs but not for LTI 1.1 form URLs.
-
michaelroytman authored
This commit replaces the consent modal that appears before personally identifiable information (PII) is shared via an LTI launch with an inline consent dialog. The consent dialog better supports the three LTI launch types (i.e. inline, modal, and new_window). This commit also fixes a bug where the PII consent modal was not being displayed for inline or modal launches.
-
- Jul 22, 2022
-
-
michaelroytman authored
This commit fixes three bugs. 1. The first bug is that the lti_version field is inappropriately hidden in the Studio author view edit menu when the selected config_type is database. 2. The second bug is that the editable_fields property of the LtiConsumerXBlock is inappropriately excluding LTI 1.3 fields when the config_type is database. The editable_fields property should include LTI 1.3 fields even when the config_type is database, because the Javascript defined in xblock_studio_view.js may want to show these fields if the user selects a different config_type in the menu. We want to support a dynamic edit menu, so these fields must be considered editable by the XBlock in order for the Javascript to be able to manipulate them. 3. The third bug is in inconsistent rendering of the Studio author view edit menu. Depending on the order in which a user selects lti_version, config_type, or lti_1p3_tool_key_mode, different sets of fields are displayed, due to the overlapping sets of rules that govern what fields should be hidden or shown for a given field selection. This commit corrects this inconsistent rendering by first showing all fields and then gradually hiding fields depending on the sets of rules, for each change to the fields.
-
- Jul 18, 2022
-
-
michaelroytman authored
This commit adds additional core LTI 1.3 and LTI Advantage variables to the LTIConfiguration model. The additional core LTI 1.3 variables are lti_1p3_oidc_url, lti_1p3_launch_url, lti_1p3_tool_public_key, and lti_1p3_tool_keyset_url. The additional LTI Advantage variables are lti_advantage_enable_nrps, lti_advantage_deep_linking_enabled, lti_advantage_deep_linking_launch_url, and lti_advantage_ags_mode. This commit also adds a configuration type to the LtiConsumerXBlock to support the storage of these LTI variables on the LTIConfiguration model (i.e. the database) instead of the xBlock itself. Changes that allow the use of this configuration option are behind the lti_consumer.enable_database_config CourseWaffleFlag.
-
- May 09, 2022
-
-
Arunmozhi authored
This adds support for loading LTI 1.1 configurations from external sources using openedx-filters. It allows the users to select the configuration provided by the filter and configure the component without explicitly entering any details.
-
- Jan 20, 2022
-
-
Felipe Trzaskowski authored
feat: add test for consumer xblock with a keyset URL feat: handle keyset URL failure cases fix: refactor and clean the tests up fix: generate translations fix: version bump
-
- Nov 22, 2021
-
-
connorhaugh authored
-
- Nov 15, 2021
-
-
connorhaugh authored
-
- Nov 12, 2021
-
-
connorhaugh authored
-
- Nov 04, 2021
-
-
connorhaugh authored
-
- Jun 03, 2021
-
-
Shimul Chowdhury authored
This depends on a new API in edx-platform: get_course_members
-
- Apr 13, 2021
-
-
Giovanni Cimolin da Silva authored
This commit re-enables the programmatic grades support on LTI AGS. This allows complex tools to manage grades on their own. The default value keeps the old behavior (declarative mode).
-
- Jan 29, 2021
-
-
Giovanni Cimolin da Silva authored
Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
-
- Aug 14, 2020
-
-
Dave St.Germain authored
Because the courseware microfrontend loads units inside iframes, the LTI modal ends up being squished and generally ugly. This PR introduces a new message sent to the parent window to request a modal containing the contents of the LTI launch iframe. https://openedx.atlassian.net/browse/TNL-7410
-
- Jun 25, 2020
-
-
Giovanni Cimolin da Silva authored
Also fixes a few untreated exceptions and remove unused variables. Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
-
Giovanni Cimolin da Silva authored
-
Giovanni Cimolin da Silva authored
-
- Nov 02, 2016
-
-
Diana Huang authored
-
- Mar 25, 2016
-
-
Douglas Hall authored
-
- Jan 26, 2016
-
-
Douglas Hall authored
-
- Dec 29, 2015
-
-
Douglas Hall authored
Toggle aria-hidden attribute on modal window open/close; Set title attribute on iframe to display name of component; Remove aria-labelledby attribute from modal body; Make modal overlay id attribute unique'
-
- Nov 30, 2015
-
-
Douglas Hall authored
-