Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T TIDO
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 110
    • Issues 110
    • List
    • Boards
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • subugoesubugoe
  • emoemo
  • TIDO
  • Merge requests
  • !256

extend usage of selectors in annotations

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Paul Pestov requested to merge feature/#372-annotation-ids into develop Apr 01, 2022
  • Overview 11
  • Commits 12
  • Pipelines 12
  • Changes 19

This MR implements the results of our discussions on working with annotation ids/ target ids and selectors. Previously the annotations feature relied only on target.id string. The connection with the text was in the end made by 'getElementbyId` in the simple case. Since the idea behind the Annotation API is to keep the content separated from the annotation object, we would "misuse" that feature by hardcoing and id selector into TIDO.

So the solution could be to mostly rely on selectors. In the Annotation API there is a target.selector object which is already used in TIDO. So we now use the selector object as a central interaction point. To track down the active/inactive state of annotations we now use annotation.ids instead of target.ids.

This also prepares the code for having a text selection feature coming up next (#365 (closed)).

closes #372 (closed)

Edited Apr 08, 2022 by Paul Pestov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/#372-annotation-ids