Merge pull request #330 from openedx/mroytman/MST-1769-pii-sharing-consent-dialog-button-bugs-copy

fix: inappropriate instructions for inline PII sharing consent dialog

CHANGELOG.rst

@@ -16,6 +16,11 @@ Please See the [releases tab](https://github.com/openedx/xblock-lti-consumer/rel
 Unreleased
 ~~~~~~~~~~
 
+8.0.1 - 2023-02-03
+------------------
+* This releases fixes the PII sharing consent dialog for inline launches to no longer refer to a nonexistent
+  "Cancel" button.
+
 8.0.0 - 2023-01-31
 ------------------
 * Update to work with bleachk>=6.0.0 and make that an explicit requirement in

lti_consumer/__init__.py

@@ -4,4 +4,4 @@ Runtime will load the XBlock class from here.
 from .apps import LTIConsumerApp
 from .lti_xblock import LtiConsumerXBlock
 
-__version__ = '8.0.0'
+__version__ = '8.0.1'

lti_consumer/static/js/xblock_lti_consumer.js

@@ -154,15 +154,21 @@ function LtiConsumerXBlock(runtime, element) {
 
         function renderPIIConsentPromptIfRequired(onSuccess, showCancelButton=true) {
             if (askToSendUsername && askToSendEmail) {
-                msg = gettext("Click OK to have your username and e-mail address sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information.");
+                msg = "Click OK to have your username and e-mail address sent to a 3rd party application.";
             } else if (askToSendUsername) {
-                msg = gettext("Click OK to have your username sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information.");
+                msg = "Click OK to have your username sent to a 3rd party application.";
             } else if (askToSendEmail) {
-                msg = gettext("Click OK to have your e-mail address sent to a 3rd party application.\n\nClick Cancel to return to this page without sending your information.");
+                msg = "Click OK to have your e-mail address sent to a 3rd party application.";
             } else {
                 onSuccess("OK");
                 return;
             }
+
+            if (showCancelButton) {
+                msg += "\n\nClick Cancel to return to this page without sending your information.";
+            }
+
+            msg = gettext(msg);
             $.when(confirmDialog(msg, $(this), showCancelButton)).then(onSuccess);
         }