- Apr 21, 2021
-
-
Giovanni Cimolin da Silva authored
-
Giovanni Cimolin da Silva authored
This fixes issues with some tools that assume `aud` as a plaing string even though that doesn't follow https://tools.ietf.org/html/rfc7519#section-4.1.3
-
- Apr 13, 2021
-
-
Muhammad Soban Javed authored
* Revert "chore: Replace jsonfield2 with jsonfield" This reverts commit 2fd330f8. * fix: only kept jsonfield related revert changes and rest are removed
-
Giovanni Cimolin da Silva authored
This commit improves the functionality of the grade publishing method. Improvements: * Doesn't publish grade to LMS if this isn't a graded block. * Doesn't try to publish grades when LineItem is not linked (`resourceLinkId` is empty) * Improves logging and properly logs exceptions
-
Giovanni Cimolin da Silva authored
This commit re-enables the programmatic grades support on LTI AGS. This allows complex tools to manage grades on their own. The default value keeps the old behavior (declarative mode).
-
- Apr 09, 2021
-
-
stvn authored
Fall-back to the old path. Once the LMS has fully switched over to this new path [1], we can remove the legacy (LMS) import support here. - [1] https://github.com/edx/edx-platform/pull/27289
-
- Mar 22, 2021
-
-
Soban Javed authored
-
- Mar 19, 2021
-
-
Ned Batchelder authored
-
- Mar 18, 2021
-
-
Giovanni Cimolin da Silva authored
* Improve content presentation and add multiple content display support This commit: * Improves LTI content presentation handling, and correctly displays LTI DL content in the LMS * Adds support for presenting multiple DL content items on the same block * Addressing review comments * Nits * Improve test and fix issue [BD-24][TNL-8072]
-
- Mar 03, 2021
-
-
Giovanni Cimolin da Silva authored
* Improve logging and error message presentation * Add full deep linking content data on studio * Internationalize LTI 1.3 templates * Add translation tooling Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com> * Update translations * Address review comments * Additional logging improvements * Address review comments, fix test Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
-
- Feb 25, 2021
-
-
stvn authored
The difficulty here is that the empty string in an invalid JSON dictionary (as opposed to None/NULL or '{}' which is just "blank"); attempts to instantiate models would fail, given the invalid data. This meant we couldn't use the Django ORM to handle the migration entirely; we need to craft some raw SQL to work-around these checks and limitations. Related-To: 42a9e342 Related-To: https://github.com/edx/xblock-lti-consumer/pull/144
-
- Feb 24, 2021
-
-
stvn authored
The previous backfills handled NULL entries; this handles empty strings. The difficulty here was that since the empty string in an invalid UUID (as opposed to None/NULL which is just "blank"), attempts to instantiate models would fail, given the invalid data. This meant we couldn't use the Django ORM to handle the migration entirely; we need to craft some raw SQL to work-around these checks and limitations.
-
- Feb 23, 2021
-
-
Giovanni Cimolin da Silva authored
* Implement ltiResourceLink content presentation Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com> * Add tests * Fix serializer required fields issue Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com> * Update version and changelog
-
- Feb 16, 2021
-
-
Shimul Chowdhury authored
-
Shimul Chowdhury authored
Add test for image Fix broken tests Add `html` content type serializer
-
Shimul Chowdhury authored
Fix broken tests Add serializer for `link` content type
-
Shimul Chowdhury authored
-
- Feb 08, 2021
-
-
SaadYousaf authored
-
- Feb 04, 2021
-
-
stvn authored
To correct the, in our case, single database entry that snuck in without a UUID during the schema change. Steps: - Make the field editable - Add `config_id` to all models missing it - Make the field noneditable again
-
- Jan 29, 2021
-
-
Giovanni Cimolin da Silva authored
This implements the endpoint that LTI tools use to return the deep linking configuration to the LMS, along with the `ltiResourceLink` type to allow testing with demo tool. Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
-
Giovanni Cimolin da Silva authored
Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com>
-
- Jan 25, 2021
-
-
usamasadiq authored
-
- Jan 21, 2021
-
-
edX requirements bot authored
-
- Jan 20, 2021
-
-
Kshitij Sobti authored
A previous PR (#130) added a new unique field with a default value to the LtiConfiguration model. Such cases need special handling in migraiton, however the previous PR did not include that. This commit fixes the migration to include the special handling for new unique fields.
-
- Jan 19, 2021
-
-
Giovanni Cimolin da Silva authored
Remove the OIDC view from XBlock and return OIDC url directly.
-
- Jan 15, 2021
-
-
Kshitij Sobti authored
-
- Dec 17, 2020
-
-
stvn authored
otherwise this blows up, trying to migrate a record with no location (the modulestore lookup throws). Presumably this isn't (wasn't?) an issue in prod already, right? But I did hit this in my devstack, having previously created an LtiConfiguration record via Django Admin (without a location).
-
- Nov 20, 2020
-
-
Ned Batchelder authored
-
Shimul Chowdhury authored
[BD-24] [TNL-7661] [BB-3172] LTI Improvements - Use declarative grading model on XBlock launch (#116) * create default LineItem, WIP grade save * add score to django admin * WIP: find user and save grade to xblock * boolean pragramatic grade interaction flag and optional params in enable_ags method * Submit grades using grade signals * lineitem urls should be optional * lineitem is now readonly in declarative method * test grade_submit called properly * quality issue * raise LTIError * moved listener to signal.py, refactored models.py, added due and start date, updated tests. * use load_block_as_anonymous_user and remove load_block, refactor tests * refactor test to fix quality issue * make lineitems_url required * refactor tests, accept_grades_past_due on check * test accept_grades_past_due * add comma to last items * refactor get_lti_ags_lineitems_url * make sure crum returns user and not None * nitpicks & use maximum score when given score is larger than maximum * fix docstring of load_block_as_anonymous_user
-
- Nov 12, 2020
-
-
Giovanni Cimolin da Silva authored
* Move LTI 1.3 Key management to model This: - Removes the need to load the modulestore on every public keyset endpoint call. - Simplifies the block structure and parent method overrides. - Removes private key, client id and related parameters from XBlock fields It also includes a migration from the data stored in the block to the model. * Cleanup unused test helpers * Version bump * Addressing review comments
-
- Nov 10, 2020
-
-
Giovanni Cimolin da Silva authored
-
- Oct 23, 2020
-
-
Patrick Cockwell authored
* BD-24 Implement LTI AGS Score Publish Service and Results Service * Address PR comments and add more validation * Address PR comments * Add tests; Fix error with scoreMaximum; Fix quality issues; Adjust user_id results url slightly * Add permissions tests and address other PR comments * Fix quality test * Address PR comments
-
- Oct 05, 2020
-
-
Giovanni Cimolin da Silva authored
* Add initial version of LineItem Implementation Signed-off-by:
Giovanni Cimolin da Silva <giovannicimolin@gmail.com> * Adding tests * Add LTI tests and fix quality isses * Quality nit * Add missing requirement, upgrade * Squash migrations * Fix merge conflicts * Addressing review comments
-
- Sep 29, 2020
-
-
Giovanni Cimolin da Silva authored
* Add django url testing support * Add tests to django views, implement compat layer * Addressing review comments * Improve tests and test descriptions * Nit
-
- Sep 24, 2020
-
-
Ned Batchelder authored
-
- Sep 22, 2020
-
-
Giovanni Cimolin da Silva authored
* Implement extensions and view support for LTI * Add missing iss to token * Add missing requirement, upgrade requirements * Improving comment * Add missing exception statement * Update lti_consumer/lti_1p3/tests/extensions/rest_framework/test_authentication.py Co-authored-by:
Ned Batchelder <ned@nedbatchelder.com> Co-authored-by:
Ned Batchelder <ned@nedbatchelder.com>
-
- Sep 15, 2020
-
-
Sankar Raj authored
Co-authored-by:
Sankar Raj <sankar.raj@crystaldelta.com>
-
- Sep 14, 2020
-
-
Ned Batchelder authored
-
Ned Batchelder authored
-
- Sep 04, 2020
-
-
Ned Batchelder authored
-