Skip to content
Snippets Groups Projects
  1. Apr 21, 2021
  2. Apr 13, 2021
  3. Apr 09, 2021
  4. Mar 22, 2021
  5. Mar 19, 2021
  6. Mar 18, 2021
  7. Mar 03, 2021
  8. Feb 25, 2021
    • stvn's avatar
      fix: Manually backfill lti_config dicts · 7082a991
      stvn authored
      The difficulty here is that the empty string in an invalid JSON
      dictionary (as opposed to None/NULL or '{}' which is just "blank");
      attempts to instantiate models would fail, given the invalid data. This
      meant we couldn't use the Django ORM to handle the migration entirely;
      we need to craft some raw SQL to work-around these checks and
      limitations.
      
      Related-To: 42a9e342
      Related-To: https://github.com/edx/xblock-lti-consumer/pull/144
      7082a991
  9. Feb 24, 2021
    • stvn's avatar
      fix: Manually backfill config_id UUIDs again · 42a9e342
      stvn authored
      The previous backfills handled NULL entries;
      this handles empty strings.
      
      The difficulty here was that since the empty string in an invalid UUID
      (as opposed to None/NULL which is just "blank"), attempts to instantiate
      models would fail, given the invalid data. This meant we couldn't use
      the Django ORM to handle the migration entirely; we need to craft some
      raw SQL to work-around these checks and limitations.
      42a9e342
  10. Feb 23, 2021
  11. Feb 16, 2021
  12. Feb 08, 2021
  13. Feb 04, 2021
    • stvn's avatar
      fix: Migrate the UUID backfill again · 8b17e4a6
      stvn authored
      To correct the, in our case, single database entry that snuck in without
      a UUID during the schema change.
      
      Steps:
      - Make the field editable
      - Add `config_id` to all models missing it
      - Make the field noneditable again
      8b17e4a6
  14. Jan 29, 2021
  15. Jan 25, 2021
  16. Jan 21, 2021
  17. Jan 20, 2021
    • Kshitij Sobti's avatar
      Fix migration `config_id` conflict. · 59b7c431
      Kshitij Sobti authored
      A previous PR (#130) added a new unique field with a default value to the
      LtiConfiguration model. Such cases need special handling in migraiton, however
      the previous PR did not include that. This commit fixes the migration to include
      the special handling for new unique fields.
      59b7c431
  18. Jan 19, 2021
  19. Jan 15, 2021
  20. Dec 17, 2020
    • stvn's avatar
      Skip migration when no LTI XBlock location exists · 9f326ee8
      stvn authored
      otherwise this blows up, trying to migrate a record with no location
      (the modulestore lookup throws).
      
      Presumably this isn't (wasn't?) an issue in prod already, right?
      But I did hit this in my devstack, having previously created an
      LtiConfiguration record via Django Admin (without a location).
      9f326ee8
  21. Nov 20, 2020
    • Ned Batchelder's avatar
      b5c1f66f
    • Shimul Chowdhury's avatar
      [BD-24] [TNL-7661] [BB-3172] LTI Improvements - Use declarative grading model... · 8b72fb9a
      Shimul Chowdhury authored
      [BD-24] [TNL-7661] [BB-3172] LTI Improvements - Use declarative grading model on XBlock launch (#116)
      
      * create default LineItem, WIP grade save
      
      * add score to django admin
      
      * WIP: find user and save grade to xblock
      
      * boolean pragramatic grade interaction flag and optional params in enable_ags method
      
      * Submit grades using grade signals
      
      * lineitem urls should be optional
      
      * lineitem is now readonly in declarative method
      
      * test grade_submit called properly
      
      * quality issue
      
      * raise LTIError
      
      * moved listener to signal.py, refactored models.py, added due and start date, updated tests.
      
      * use load_block_as_anonymous_user and remove load_block, refactor tests
      
      * refactor test to fix quality issue
      
      * make lineitems_url required
      
      * refactor tests, accept_grades_past_due on check
      
      * test accept_grades_past_due
      
      * add comma to last items
      
      * refactor get_lti_ags_lineitems_url
      
      * make sure crum returns user and not None
      
      * nitpicks & use maximum score when given score is larger than maximum
      
      * fix docstring of load_block_as_anonymous_user
      8b72fb9a
  22. Nov 12, 2020
    • Giovanni Cimolin da Silva's avatar
      [BD-24] [TNL-7607] BB-3072: Move key and client management to model level. (#113) · 9ac5fda4
      Giovanni Cimolin da Silva authored
      * Move LTI 1.3 Key management to model
      
      This:
      - Removes the need to load the modulestore on every public keyset endpoint call.
      - Simplifies the block structure and parent method overrides.
      - Removes private key, client id and related parameters from XBlock fields
      
      It also includes a migration from the data stored in the block to the model.
      
      * Cleanup unused test helpers
      
      * Version bump
      
      * Addressing review comments
      9ac5fda4
  23. Nov 10, 2020
  24. Oct 23, 2020
    • Patrick Cockwell's avatar
      [BD-24] Implement LTI AGS Score Publish Service and Results (#108) · 5fc16b38
      Patrick Cockwell authored
      * BD-24 Implement LTI AGS Score Publish Service and Results Service
      
      * Address PR comments and add more validation
      
      * Address PR comments
      
      * Add tests; Fix error with scoreMaximum; Fix quality issues; Adjust user_id results url slightly
      
      * Add permissions tests and address other PR comments
      
      * Fix quality test
      
      * Address PR comments
      5fc16b38
  25. Oct 05, 2020
  26. Sep 29, 2020
  27. Sep 24, 2020
  28. Sep 22, 2020
  29. Sep 15, 2020
  30. Sep 14, 2020
  31. Sep 04, 2020
Loading