Skip to content
Snippets Groups Projects
  1. Apr 17, 2023
  2. Apr 12, 2023
  3. Apr 11, 2023
  4. Mar 06, 2023
    • Geoff's avatar
      299 validate redirect uris (#302) · 6c9c0ef3
      Geoff authored
      * Adds lti_1p3_redirect_uris to XBlock
      * Adds lti_1p3_redirect_uris to LTIConfiguration model
      * Asserts redirect_uri from preflight response in valid redirect uris during preflight validation
      * To minimize disruption for previous versions, uses current launch url and deep linking url as default registered redirect_uris if redirect_uris is not explicitly set
      6c9c0ef3
  5. Feb 03, 2023
    • michaelroytman's avatar
      fix: inappropriate instructions for inline PII sharing consent dialog · dcf80007
      michaelroytman authored
      This commit fixes inappropriate instructions displayed when collecting PII sharing consent before an inline LTI launch. Previously, the instructions said, "Click OK to have your [username (and) e-mail address] sent to a 3rd party application. Click Cancel to return to this page without sending your information." The latter sentence does not make sense in the context of an inline launch, because there is no cancel button. This commit modifies the inline PII sharing consent dialog to say, "Click OK to have your [username (and) e-mail address] sent to a 3rd party application.""
      dcf80007
  6. Jan 31, 2023
  7. Jan 30, 2023
  8. Jan 24, 2023
    • michaelroytman's avatar
      fix: bug in rending buttons and message in PII sharing consent dialog · d95de6e8
      michaelroytman authored
      This commit fixes a bug in the PII sharing consent dialog.
      
      The bug resulted in bizarre behavior when there were more than one LTI component in a unit. For example, if there were two LTI inline launches in a unit, two "OK" button would appear in a single component, instead of in their respective components. Another example is that clicking the "View resource in a [modal|new] window" buttons under two LTI components resulted in the "OK" and "Cancel" buttons as well as the PII sharing prompt appearing in a single component, instead of in their respective components.
      
      This is because the dialog-container div that is dynamically created in the Javascript was not scoped to the LTI component, so there was a div with a id of "dialog-container" for each component configured to share PII. When dynamically inserting and removing buttons and the PII sharing prompt, the Javascript would simply find the first div with the dialog-container ID and operate on it, instead of the div appropriate to the component the user is interacting with.
      d95de6e8
    • Zachary Hancock's avatar
      fix: failing AGS test (#326) · 53823ea8
      Zachary Hancock authored
      53823ea8
    • Giovanni Cimolin da Silva's avatar
      Merge pull request from GHSA-7j9p-67mm-5g87 · 252f94bd
      Giovanni Cimolin da Silva authored
      
      * fix: Tool can only push grade to value in config
      
      Before this commit, LTI tools were able to push grades to any block
      simply by modifying or creating a new line item with a `resource_link_id` containing a valid block.
      
      This commit closes that loophole and resolves
      security advisory GHSA-7j9p-67mm-5g87.
      
      * chore: create release version
      
      Co-authored-by: default avatarZach Hancock <zhancock@edx.org>
      252f94bd
  9. Jan 10, 2023
  10. Dec 15, 2022
    • michaelroytman's avatar
    • michaelroytman's avatar
      feat: enable sharing username, email in LTI 1.3 launches and support blocking PII transmission · a7fcf621
      michaelroytman authored
      This commit enables sharing username and email in LTI 1.3 basic launches.
      
      This commit adds preferred_username and email as attributes of the Lti1p3LaunchData. The application or context that instantiates Lti1p3LaunchData is responsible for ensuring that username and email can be sent via an LTI 1.3 launch and supplying these data, if appropriate.
      
      This commit sends username and email as part of an LTI 1.3 basic launch when the XBlock fields ask_to_send_username and ask_to_send_email are set to True, respectively.
      
      Code was also added to block the transmission of username and email in both LTI 1.1 and LTI 1.3 launches if the value of the lti_access_to_learners_editable method of the LTI configuration service (i.e. the value of the CourseAllowPIISharingInLTIFlag ConfigurationModel) returns False, as originally intended and documented in the "Unified Flag for Enabling Sharing of PII in LTI
      " decision record. However, the LTI configuration service is not currently available or defined in all runtime contexts, so this behavior only works when editing the XBlock in Studio (i.e. the studio_view). It does not work from the XBlock preview in Studio (i.e. the author_view) or from the LMS (i.e. the student_view).
      
      The impact of this is that the ask_to_send_username and ask_to_send_email fields will be hidden in LTI XBlocks in courses for which an instance of the CourseAllowPIISharingInLTIFlag ConfigurationModel does not exist or for which an existing instance of the CourseAllowPIISharingInLTIFlag ConfigurationModel is disabled. If there already exists an instance of the CourseAllowPIISharingInLTIFlag ConfigurationModel for a course, then disabling the flag will only hide the ask_to_send_username and ask_to_send_email in the LTI XBlock edit menu. It will not prevent the transmission of username or email via the launch in Studio preview or via the launch in the LMS. If a course has already set ask_to_send_username or ask_to_send_email to True in the XBlock edit menu, that information will continue to be sent via the LTI 1.1 or LTI 1.3 launch.
      
      We plan to fix this bug in the future.
      a7fcf621
    • michaelroytman's avatar
      fix: LTI 1.1 form URL is relative URL and LTI 1.3 form URL is expected to be absolute · e1e0f131
      michaelroytman authored
      This commit fixes a bug in the way that the the form_url is used in the Javascript.
      
      For LTI modal launches in the courseware microfrontend (MFE), the Javascript prepends the value of window.location.origin to the form_url when sending a message via postMessage to window.parent.
      
      This is because the form_url included in the template by the XBlock handler does not include a port and hostname for LTI 1.1 launches.
      
      In LTI 1.3, however, the form_url should include the port and hostname, because it's user input (e.g. fields on the XBlock). Because of this, LTI 1.3 modal launches do not work, because the Javascript appends a port and hostname to a URL that already has a port and hostname, resulting in something like "http://localhost:18000http//localhost..."
      
      This commit changes the way that the launch URL is calculated by the Javascript. The version of LTI being used is included in the template by the Python code, which is read by the Javascript. The Javascript then adds the port and hostname for LTI 1.1 form URLs but not for LTI 1.1 form URLs.
      e1e0f131
    • michaelroytman's avatar
      fix: remove caching for lti_access_to_learners_editable · d70de329
      michaelroytman authored
      This commit removes the request_cached decorator on the method lti_access_to_learners_editable. The caching was not working correctly. It appeared that the cached value was not being recomputed on a per-request basis, which meant that the cached value was not successfully being updated. Also, the initial cached value was computed incorrectly. The effect was that the PII sharing XBlock fields were always being displayed in Studio and CourseAllowPIISharingInLTIFlag instances were not being created for courses that had PII sharing XBlocks that did not already have CourseAllowPIISharingInLTIFlag instances.
      
      Note that this commit fixes the backwards compatibility of the CourseAllowPIISharingInLTIFlag. This means that CourseAllowPIISharingInLTIFlag will now be created for all courses that contain an LTI XBlock that shares username and/or email for which a CourseAllowPIISharingInLTIFlag does not already exist.
      
      Time was spent on determining why the caching was failing, but it was challenging. If the issue is in the request_cached decorator, then the impact of changing it is large - it's used elsewhere in the platform. The need for a fix was urgent, and the supposed performance enhancement of leaving the caching in doesn't justify delaying a fix.
      d70de329
    • michaelroytman's avatar
      feat: replace PII consent modal with inline PII consent dialog and show for all LTI launch types · 8e357d40
      michaelroytman authored
      This commit replaces the consent modal that appears before personally identifiable information (PII) is shared via an LTI launch with an inline consent dialog. The consent dialog better supports the three LTI launch types (i.e. inline, modal, and new_window). This commit also fixes a bug where the PII consent modal was not being displayed for inline or modal launches.
      8e357d40
  11. Dec 09, 2022
    • Zachary Hancock's avatar
      feat: adds setting to prevent nrps pii (#315) · 3f2bab5e
      Zachary Hancock authored
      We would like to enable PII in an LTI1.3 launch but turning that flag on would allow the tool to grab PII for the entire course roster via NRPS. We have not fully evaluated the privacy concerns if that is allowed. For the time being this platform setting can wholly disable PII over NRPS to avoid the issue
      3f2bab5e
  12. Dec 02, 2022
  13. Nov 29, 2022
  14. Nov 28, 2022
    • Arunmozhi's avatar
      refactor: replace oauth param fetching from client to signature method · 4e388eac
      Arunmozhi authored
      The OAuthlib 1.0 Client's get_oauth_params fails when processing Webob
      request object with the body stored as a binary instead of string.
      This commit replaces the client function with a different one which
      doesn't involve body hashing, as the body hash is calculated explicitly.
      4e388eac
  15. Nov 21, 2022
  16. Nov 18, 2022
    • michaelroytman's avatar
      feat: add course flag to send external_user_id as user_id in LTI 1.1 XBlock launches · cff7744e
      michaelroytman authored
      This commit introduces a new CourseWaffleFlag lti_consumer.enable_external_user_id_1p1_launches. When this flag is enabled for a course, LTI 1.1 XBlock launches in that course will send the user's external_user_id as the user_id attribute of the launch. external_user_id is the user's external user ID as defined, created, and stored by the external_user_ids Djangoapp in the edx-platform. When this waffle is not enabled for a course - the default case - LTI 1.1 XBlock launches in that course will continue to send the user's anonymous_user_id as the user_id attribute of the launch, as before.
      
      This provides an opt-in opportunity for courses to send a consistent, static, and opaque user identifier in an LTI 1.1 XBlock launch. This may be necessary for integration with LTI tools that require such an identifier.
      
      Please be aware that toggling this flag in a running course carries the risk of breaking the LTI integrations in the course. This flag should also only be enabled for new courses in which no LTI attempts have been made.
      cff7744e
  17. Nov 16, 2022
  18. Nov 07, 2022
    • Andy Shultz's avatar
      fix: remove general use of load_block_as_user · 5f964f1d
      Andy Shultz authored
      For the config model we do not need to go as far as binding the block
      to the user and already get enough data out of the modulestore to
      satisfy the storage on the xblock case. Add a new function to get that
      much xblock only.
      
      For the limited cases where we are using the block more directly as a
      block we maintain the old function.
      
      Also includes a fix to test_views that was closing the wrong level
      mock and leaving an open patch into other tests.
      5f964f1d
  19. Oct 25, 2022
  20. Oct 20, 2022
Loading